Skip to content

Conversation

@Pana
Copy link
Member

@Pana Pana commented Jun 23, 2025

This change is Reviewable

Pana added 2 commits June 17, 2025 18:02
update tx pool packing select order from gas_price to max_priority_gas_price
@Pana Pana changed the title Op/pool order feat: change tx pool packing order from gas_price to max_priority_price_per_gas Jun 23, 2025
adapt change logic

remove useless comment
Copy link
Contributor

@ChenxingLi ChenxingLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 15 files at r1, all commit messages.
Reviewable status: 3 of 15 files reviewed, 2 unresolved discussions


crates/cfxcore/packing-pool/src/packing_batch.rs line 112 at r1 (raw file):

        if tx.nonce() + 1 < start_nonce
            || (tx.nonce() + 1 == start_nonce
                && tx.max_priority_gas_price()

I'm not sure if simply replacing gas_price with priority_gas_price is appropriate.


crates/cfxcore/core/src/verification.rs line 121 at r1 (raw file):

/// Compute epoch receipts root.
/// This value is stored in the `deferred_receipts_root` header field.
pub fn compute_epoch_receipts_root(

Renaming functions unrelated to PR modification logic is prohibited.

Copy link
Member Author

@Pana Pana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 15 files reviewed, 2 unresolved discussions (waiting on @ChenxingLi)


crates/cfxcore/core/src/verification.rs line 121 at r1 (raw file):

Previously, ChenxingLi (Chenxing Li) wrote…

Renaming functions unrelated to PR modification logic is prohibited.

Done.

@Pana
Copy link
Member Author

Pana commented Jun 24, 2025

retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants